Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indonesian language support #56

Merged
merged 4 commits into from
Oct 7, 2019
Merged

Add Indonesian language support #56

merged 4 commits into from
Oct 7, 2019

Conversation

harkce
Copy link
Contributor

@harkce harkce commented Oct 4, 2019

Implements #45

@harkce harkce requested a review from moul as a code owner October 4, 2019 03:40
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 4, 2019
id-id.go Outdated
}

// IntegerToIdId converts an integer to Indonesian words
func IntegerToIdId(input int) string {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func IntegerToIdId should be IntegerToIDID (from golint)

Copy link
Owner

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thx!

@moul moul merged commit 409d449 into moul:master Oct 7, 2019
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet ✅ Approved Pull Request has been approved and can be merged labels Oct 7, 2019
@moul moul mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants