Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set checkLocalVariables to true on jsx-handler-names rules #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ruimonteiro93
Copy link

This is to ensure that all event handlers are properly named, according to the rules specified.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #91 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines           42        42           
  Branches         1         1           
=========================================
  Hits            42        42           
Impacted Files Coverage Δ
packages/eslint-config-react/lib/rules/react.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235f9b3...a82f985. Read the comment docs.

Copy link
Contributor

@acostalima acostalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@satazor
Copy link
Contributor

satazor commented Mar 27, 2020

While not intentional, this is a breaking change correct?

@satazor
Copy link
Contributor

satazor commented Mar 30, 2020

Object {
"column": 43,
"line": 4,
"rule": "react/jsx-handler-names",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error shouldn't happen as the function is anonymous.. I guess that's a deal breaker for now, see: jsx-eslint/eslint-plugin-react#2586

@acostalima
Copy link
Contributor

@ruimonteiro93, what's the status of this? Please follow up.

@satazor
Copy link
Contributor

satazor commented Jun 10, 2020

@acostalima we can’t merge this until #91 (comment) is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants