feat: cache precision per device #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
force-pushed
the
precision-per-device
branch
2 times, most recently
from
3edb1c3
to
a0dbc66
Compare
|
It looks good so far however one test is failing, can you check it out? We are missing tests as well before merging. |
julien-f
force-pushed
the
precision-per-device
branch
from
a0dbc66
to
f285d11
Compare
|
@satazor AFAU, the problem comes from the test expecting a specific number of calls to node-proper-lockfile/test/lock.test.js Line 193 in 9f8c303 But the new algorithm, introduce an extra to get the device. |
|
Yes we need to update existing tests and generate new ones to test the new code (different devices). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #103
Quick and untested implementation.