Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-9050 [Multi-window] Throttler utility updates #20172

Merged
merged 2 commits into from
May 9, 2024

Conversation

mattreaganmozilla
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Minor adjustments to our Throttler to ensure that rapid consecutive calls will not prevent code from ever being called (it should be called at most once per N seconds). Updates related unit tests.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.66%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 31.28

File Coverage
Throttler.swift 91.67%
WindowTabsSyncCoordinator.swift 91.18%

Generated by 🚫 Danger Swift against b41d516

@mattreaganmozilla
Copy link
Collaborator Author

cc @OrlaM @nbhasin2 Going to merge this but wanted to get your eyes on it if you have a moment. LMK if any concerns etc., I'm happy to revisit anything or open a follow-up PR.

@mattreaganmozilla mattreaganmozilla merged commit 6a47c97 into mozilla-mobile:main May 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants