This repository has been archived by the owner on Apr 27, 2023. It is now read-only.
Decommisioning extension #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
reviewed
Apr 11, 2023
| @@ -85,6 +85,12 @@ export default class Core { | |||
| browser.browserAction.onClicked.addListener(this._openControlPanel); | |||
| // After installing the addon, make sure to show the control page. | |||
| browser.runtime.onInstalled.addListener(async ({ reason, temporary }) => { | |||
| // If core-addon is to be revived, then remove lines starting here... | |||
There was a problem hiding this comment.
I believe we should be clearing the storage as well and potentially uninstalling all the studies. e.g. do what this is doing.
Or is there a different plan?
There was a problem hiding this comment.
We actually don't want to do "unenroll" as that will send data deletion requests – and we have some customers that are still doing analysis. We also don't need to uninstall studies because we are pushing "self-uninstalling" updates for all studies.
There was a problem hiding this comment.
(we preferred to have studies uninstall themselves rather than via Core Add-on, in case some people had studies installed without Core Add-on)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decommissioning the core addon.