This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
generated from mozilla-rally/study-template
-
Notifications
You must be signed in to change notification settings - Fork 3
[DO NOT MERGE] Comments on the current implementation #14
Open
jonathanmayer
wants to merge
513
commits into
comments
Choose a base branch
from
main
base: comments
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanmayer
commented
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big-picture comments:
- There is way too much repetition in here. You're creating more work for yourself and inviting bugs. I suspect you could cut this codebase nearly in half.
- The documentation still needs a lot of work.
…lint-plugin-mocha-9.0.0 Bump eslint-plugin-mocha from 8.1.0 to 9.0.0
…lint-7.32.0 Bump eslint from 7.26.0 to 7.32.0
…llup/plugin-node-resolve-13.0.4 Bump @rollup/plugin-node-resolve from 13.0.0 to 13.0.4
Bumps [@rollup/plugin-replace](https://github.com/rollup/plugins/tree/HEAD/packages/replace) from 2.4.2 to 3.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/replace/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/wasm-v3.0.0/packages/replace) --- updated-dependencies: - dependency-name: "@rollup/plugin-replace" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…llup/plugin-replace-3.0.0 Bump @rollup/plugin-replace from 2.4.2 to 3.0.0
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 19.0.0 to 20.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v20.0.0/packages/commonjs) --- updated-dependencies: - dependency-name: "@rollup/plugin-commonjs" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@mozilla/rally](https://github.com/mozilla-rally/rally-core-addon/tree/HEAD/support) from 0.6.0 to 0.7.0. - [Release notes](https://github.com/mozilla-rally/rally-core-addon/releases) - [Changelog](https://github.com/mozilla-rally/rally-core-addon/blob/v0.7.0/CHANGELOG.md) - [Commits](https://github.com/mozilla-rally/rally-core-addon/commits/v0.7.0/support) --- updated-dependencies: - dependency-name: "@mozilla/rally" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [web-ext](https://github.com/mozilla/web-ext) from 6.1.0 to 6.4.0. - [Release notes](https://github.com/mozilla/web-ext/releases) - [Commits](mozilla/web-ext@6.1.0...6.4.0) --- updated-dependencies: - dependency-name: web-ext dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…llup/plugin-commonjs-20.0.0 Bump @rollup/plugin-commonjs from 19.0.0 to 20.0.0
…b-ext-6.4.0 Bump web-ext from 6.1.0 to 6.4.0
…zilla/rally-0.7.0 Bump @mozilla/rally from 0.6.0 to 0.7.0
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.0.0-beta.3 to 4.0.0-rc-1. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.0.0-rc-1) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
upgrade to latest rally-sdk and add Rally Web Platform support
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/HEAD/packages/node-resolve) from 13.0.4 to 13.0.5. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/node-resolve-v13.0.5/packages/node-resolve) --- updated-dependencies: - dependency-name: "@rollup/plugin-node-resolve" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.56.3 to 2.57.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.56.3...v2.57.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…lenium-webdriver-4.0.0-rc-1 Bump selenium-webdriver from 4.0.0-beta.3 to 4.0.0-rc-1
…llup/plugin-node-resolve-13.0.5 Bump @rollup/plugin-node-resolve from 13.0.4 to 13.0.5
…llup-2.57.0 Bump rollup from 2.56.3 to 2.57.0
Bumps [mocha](https://github.com/mochajs/mocha) from 9.1.1 to 9.1.2. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](mochajs/mocha@v9.1.1...v9.1.2) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cha-9.1.2 Bump mocha from 9.1.1 to 9.1.2
…g download button
Bumps [eslint-plugin-mocha](https://github.com/lo1tuma/eslint-plugin-mocha) from 8.2.0 to 10.1.0. - [Release notes](https://github.com/lo1tuma/eslint-plugin-mocha/releases) - [Changelog](https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/CHANGELOG.md) - [Commits](lo1tuma/eslint-plugin-mocha@8.2.0...10.1.0) --- updated-dependencies: - dependency-name: eslint-plugin-mocha dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [webextension-polyfill](https://github.com/mozilla/webextension-polyfill) from 0.8.0 to 0.9.0. - [Release notes](https://github.com/mozilla/webextension-polyfill/releases) - [Commits](mozilla/webextension-polyfill@0.8.0...0.9.0) --- updated-dependencies: - dependency-name: webextension-polyfill dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…bextension-polyfill-0.9.0 Bump webextension-polyfill from 0.8.0 to 0.9.0
…lint-plugin-mocha-10.1.0 Bump eslint-plugin-mocha from 8.2.0 to 10.1.0
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 19.0.2 to 22.0.2. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v22.0.2/packages/commonjs) --- updated-dependencies: - dependency-name: "@rollup/plugin-commonjs" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…kodriver-2.0.4 Bump geckodriver from 1.22.3 to 2.0.4
Submit commits to Glean probe-scraper
This reverts commit 356d046.
…llup/plugin-commonjs-22.0.2 Bump @rollup/plugin-commonjs from 19.0.2 to 22.0.2
…rowser.alarms instead of recursive calls to setTimeout
…rowser.alarms instead of recursive calls to setTimeout
…esults count for all SERPs
…SERP parsing breaking does not affect other components
…ngine option and lottery functionality, also updated followup survey with Brave but did not create new survey as we have no responses for this yet
Decommision via self-uninstall
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.