Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend test fix for spec-ci failures #732

Merged

Conversation

nthomas-mozilla
Copy link
Contributor

Try specifying commander version

@nthomas-mozilla
Copy link
Contributor Author

This is for bug 1481168. The back-end tests will be fixed by pull #731 .

@nthomas-mozilla
Copy link
Contributor Author

@JohanLorenzo helped me track this down to the commander change tj/commander.js#778 using arrow functions, and our node is sufficiently old (0.10.mumble) that they're unsupported. If you hack up node_modules/lineman/tasks/spec-ci.coffee to show you stderr you get this with commander 2.17.0:

Running "spec-ci" task

/app/ui/node_modules/testem/node_modules/commander/index.js:663
    if (this._args.filter(a => a.required).length === 0) {
                             ^

We're planning to rewrite the UI this quarter so pinning commander is no worse than the current situation.

Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this fix, for the time being.

@nthomas-mozilla nthomas-mozilla merged commit e76cca7 into mozilla-releng:master Aug 7, 2018
@nthomas-mozilla nthomas-mozilla deleted the frontend-test-fix branch August 7, 2018 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants