-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stmux for yarn dev to multiplex process output #88
Conversation
@willdurand @bobsilverberg Before I add documentation, what do you think? Is it too prescriptive? If so, we could just expose |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 62.59% 62.59%
=======================================
Files 10 10
Lines 131 131
Branches 26 26
=======================================
Hits 82 82
Misses 45 45
Partials 4 4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit skeptical at first, especially because I am not sure this stmux
project is finished/well maintained and I can easily imagine issues with various OS but I love the dev experience ❤️
Let's ship it!
This is fantastic! Thanks @kumar303! |
@willdurand @bobsilverberg thanks for taking an early look. I added docs and settled on two main commands. If in the future we don't end up using them or we all use custom commands 😅 then we could consider removing them.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! r+wc
ℹ️ I noticed the yarn.lock
file was not in sync on my machine. Could you check that please?
@@ -13,6 +13,10 @@ const app = createServer({ | |||
rootPath: path.join(__dirname, '..'), | |||
}); | |||
|
|||
const printDivider = () => { | |||
console.log('\n' + '#'.repeat(60) + '\n'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
70
was used so that it was longer than the text inside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just reduced the width of all text (in a separate commit). It won't be perfect on every screen but keeping it less wide makes it slightly more versatile.
I think snyk is up to date but it probably don't like running on a branch or something |
Fixes #86
The
yarn dev
command now multiplexes all developer-y things which preserves the pleasant experience of howcreate-react-app
clears stdout as files change.yarn dev
For making use of wider screen area, there's a
yarn dev-2col
command, too.yarn dev-2col