Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily ignore lodash prototype pollution #904

Merged
merged 1 commit into from Jul 3, 2019

Conversation

kumar303
Copy link
Contributor

@kumar303 kumar303 commented Jul 2, 2019

The affected packages aren't handling our incoming JSON so this seems safe to ignore. Can someone double check that? I don't see an upstream patch yet but I set the expiry low so we can resolve this soonish.

The affected packages aren't handling incoming our JSON.
@willdurand willdurand merged commit b1a4542 into master Jul 3, 2019
@willdurand willdurand deleted the ignore-snyk-lodash branch July 3, 2019 07:53
@willdurand
Copy link
Member

I went ahead and merged this so that other PRs can be green again (hopefully)

@willdurand
Copy link
Member

I don't see an upstream patch yet but I set the expiry low so we can resolve this soonish.

Here it is: lodash/lodash#4336

@willdurand
Copy link
Member

Also: I double checked the use of _.merge, _.mergeWith and _.defaultsDeep in the node modules. Those functions don't appear to be used so there should be no problem with ignoring this issue.

@kumar303
Copy link
Contributor Author

kumar303 commented Jul 3, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants