Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore nsp issue for JSDom #3211

Merged
merged 1 commit into from Sep 22, 2017
Merged

chore: Ignore nsp issue for JSDom #3211

merged 1 commit into from Sep 22, 2017

Conversation

tofumatt
Copy link
Contributor

@tofumatt tofumatt commented Sep 22, 2017

See mozilla/addons#10799.

As discussed because we don't use FetchExternalResources for JSDom it seems we're all good here.

@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

Merging #3211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    mozilla/addons-frontend#3211   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files         158      158           
  Lines        2916     2916           
  Branches      575      575           
=======================================
  Hits         2777     2777           
  Misses        120      120           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8aa55e...0befd83. Read the comment docs.

Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ if the build passes. Thanks!

I'm pretty sure these failures were intermittent so I restarted the build.

@kumar303
Copy link
Contributor

I updated the description so that it won't close mozilla/addons#10799 . We should close that when we land the upstream patches. Ignoring it is just a workaround for now.

@tofumatt
Copy link
Contributor Author

I updated the description so that it won't close mozilla/addons#10799 . We should close that when we land the upstream patches. Ignoring it is just a workaround for now.

Ah, fair enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants