Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent error when strict_min_version is not a string value #3913

Merged
merged 1 commit into from Sep 14, 2021
Merged

Prevent error when strict_min_version is not a string value #3913

merged 1 commit into from Sep 14, 2021

Conversation

willdurand
Copy link
Member

Fixes #3909

Thanks to @rpl for the sketch of patch.

@willdurand
Copy link
Member Author

(the test-alternate job is still broken because of a Node issue FWIW)

@willdurand willdurand requested a review from rpl September 14, 2021 09:30
rpl
rpl approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willdurand thanks!

@willdurand willdurand merged commit e5e5b55 into master Sep 14, 2021
@willdurand willdurand deleted the fix-split branch September 14, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpl rpl rpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some validation messages for manifest syntax errors could be more accurate
2 participants
@willdurand @rpl