Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMP: test the node_modules named volume approach #22102

Closed
wants to merge 12 commits into from

Conversation

KevinMind
Copy link
Contributor

@KevinMind KevinMind commented Apr 2, 2024

Relates to: https://mozilla-hub.atlassian.net/browse/ADDSRV-720

Description

TMP: testing out using a docker managed volume for node_modules directory to resolve the docker/host permissions issue.

Context

This should allow us to simplify our npm setup, using the default directory, while avoiding the host/container permissions issue by makin the node_modules exist in a docker managed volume.

Testing

TBD: just testing out now.

@KevinMind
Copy link
Contributor Author

Note: This build is

  1. not failing when a test fails, this is a problem, needs to be fixed.
  2. the reason it is failing is because the files static/js/zamboni/stats-all.js is created during the docker build, but does not exist in the host when we run the container. Docker does not merge bind mounts from the host with the container file system, but replaces the path so if the file doesn't exist in the host file system when we run, it is effectively "removed" in the container.

This needs to be addressed, there are a few potential solutions:

  • make sure built files are placed in an ignored directory on the container. like "node_modules" is in the docker ignore, so it is safe for the container to write files there, the host will not overwrite them. We could put our build assets in a ./dist folder or something and then ignore that directory from the host.
  • we could make sure to re-build assets when running the contianer (inefficient, boo)
  • we could have a smarter mount volume when running, only mounting what and when we need to in CI.

@KevinMind KevinMind force-pushed the ADDSRV-720-volumes branch 14 times, most recently from 51a2c86 to 52feef4 Compare April 2, 2024 17:28
@KevinMind KevinMind marked this pull request as draft April 2, 2024 17:28
@KevinMind KevinMind force-pushed the ADDSRV-720-volumes branch 13 times, most recently from e8a2805 to 97cc025 Compare April 3, 2024 11:51
@KevinMind KevinMind force-pushed the ADDSRV-720-volumes branch 17 times, most recently from f861eab to d7c7c2e Compare April 24, 2024 08:03
TMP: remove olympia mount from ci.yml

TMP: olympia mount compose_files

TMP: remove localization
- remove circle job
- add compose config for CI environment vars
- add es-test job to verify docker image workflow

TMP: use -n

TMP: only split 2

TMP: es_test cannot be parallelized

TMP: remove Circle
- remove internal routes from circle
- add internal routes tests to GHA

TMP: remove internal routes from circle

No parlallel internal (only 15 tests)
- addons-versions-files-ratings
- amo-lib-locales-and-signing
- devhub
- main

TMP: ignore celery task

TMP: fix the fix

TMP: split tests

TMP: split devhub.. does it fix?

TMP: additional split for performance
@KevinMind KevinMind changed the base branch from master to dynamic-docker-props May 7, 2024 08:40
@KevinMind KevinMind changed the base branch from dynamic-docker-props to master May 7, 2024 08:42
@KevinMind KevinMind closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant