-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Correct wording for emails sent with appeals attached after reject or disable #1759
Comments
@wagnerand what are your thoughts about this scenario and what the messaging should be? The scenario is an add-on version is rejected and the developer appeals, but also uploads a new version. If the appeal is resolved with the Approve action on the new version (the intuitive action to take) then the email says the previous decision was incorrect. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Good question. It seems like our current workflow is incompatible with this scenario. |
It's a requirement for the appeal process. @eviljeff had some ideas about workarounds we could add - wouldn't entirely solve the problem but would be good enough to unblock us. |
The workaround would be adding something to the reviewer tools forms to allow the reviewer to choose exactly how the job should be resolved - so they could choose to both approve a new version and reject the appeal on the old version at the same time. A follow-up for a better experience would be a email template that more accurately explains the appeal become obsolete with the new version approval. |
Can this be resolved by leveraging the new "Comment on AMO Reviewer Tools and Resolve a Cinder escalation" that you're working in @eviljeff ? |
@abyrne-moz unfortunately not - it leverages a function that currently doesn't result in any action (commenting). It still won't let a reviewer take two different actions (a version approval + an appeal rejection) at the same time. My suggested workaround from 2 weeks ago was in hindsight a little naive - that a reviewer would even think to reject an appeal to resolve a job while approving a version relies on the reviewer thinking through all the scenarios and knowing what emails are sent. The mental shortcut is still "add-on is good now, appeal is good", imo, so we're leaving a footgun around. There was an alternative suggestion in one of the triage meetings (alas not documented!) to auto-reject an appeal once a developer uploads a new version that I like. |
To recreate the issue: What happens: Potential solution
Unfortunately this means we are reporting an incorrect appeal resolution to the transparency report. @abyrne-moz to check with legal and Trust&Safety to see if we can withdraw an appeal if a new version is uploaded. If so |
What happened?
Followup for #9514
What did you expect to happen?
A better choice of words.
Is there an existing issue for this?
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: