Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore changing /firefox/all/ to be less process intensive. #14324

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

robhudson
Copy link
Member

@robhudson robhudson commented Mar 15, 2024

One-line summary

This branch is an effort to eventually replace /firefox/all/ to avoid a very heavy paylaod to the browser by breaking the choices into separate pages rather than a single page.

Unfinished business

  • Clean up CSS classes and CSS file
  • Clean up JS
  • Clean up all-unified HTML/CSS/JS/tests
  • Improve wording to better explain this is a multi-step selection, not just choosing a language
  • [sh] RTL support for CSS
  • Add unit tests
  • Add integration tests
  • [rob] Make cancel button work
  • [rob] Make the mobile page display
  • [rob] Move to /all
  • [rob] make download button work
  • [sh] Remove template all-unified.html and linked styles/js
  • Add back system requirements, release notes and support links
  • hide "x" icon for language & product when viewing mobile product

Issue / Bugzilla link

#9845

Testing

This currently is hosted on demo2 at /en-US/firefox/drill/

Mobile:

  • Test on an actual mobile device.

Localization:

  • No untranslated strings
  • No unused translations (they should be deleted if we're not using them)

QR codes go to expected App/Play store:

  • Mobile
  • Android Beta
  • Android Nightly
  • Scan one to make sure it has enough size/whitespace to work

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 4.08163% with 47 lines in your changes missing coverage. Please review.

Project coverage is 76.42%. Comparing base (090c466) to head (00d80f9).
Report is 2 commits behind head on main.

Current head 00d80f9 differs from pull request most recent head d23f0fe

Please upload reports for the commit d23f0fe to get more accurate results.

Files Patch % Lines
bedrock/firefox/views.py 4.08% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14324      +/-   ##
==========================================
- Coverage   76.85%   76.42%   -0.44%     
==========================================
  Files         156      156              
  Lines        8149     8198      +49     
==========================================
+ Hits         6263     6265       +2     
- Misses       1886     1933      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephaniehobson
Copy link
Contributor

I've started but I'm not finished and I don't have time to leave notes for someone else to pick it up :/ Fortunately, there's no rush.

@stephaniehobson
Copy link
Contributor

stephaniehobson commented May 31, 2024

I pushed my most recent changes.

  • Links that need changing are href="TODO"
    • There should be 3 "back buttons" plus the download button
  • The page that needs fixing is linked on the first page under Browser > Mobile > Firefox
    • you can use the plat_mobile and lang_multi variables in views.py to construct the values for platform and language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants