-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track product click events in glean.js #14416
base: main
Are you sure you want to change the base?
Conversation
76fc66d
to
5434a0e
Compare
7ada199
to
ef426e9
Compare
ef426e9
to
c306cd9
Compare
c306cd9
to
0633230
Compare
c7eadeb
to
4113813
Compare
4113813
to
c70959f
Compare
bedrock/products/templates/products/vpn/includes/pricing-plus-relay.html
Show resolved
Hide resolved
@stephaniehobson I'm going to set this one back to draft until the consent banner PR has merged. Will revisit, thanks. |
25dee02
to
61fd001
Compare
6dc7d5f
to
d22e015
Compare
@stephaniehobson this is now rebased and ready for review, thanks. |
d22e015
to
71125e4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14416 +/- ##
==========================================
- Coverage 76.94% 76.87% -0.07%
==========================================
Files 157 156 -1
Lines 8192 8157 -35
==========================================
- Hits 6303 6271 -32
+ Misses 1889 1886 -3 ☔ View full report in Codecov by Sentry. |
One-line summary
Significant changes and points to review
Glean is only enabled on dev right now, so this should be safe to test out.
Issue / Bugzilla link
N/A
Testing
make preflight
npm start
window.Glean.setLogPings(true)
in the web console and refresh the page to view raw ping logs as you click element in a page.Persist Logs
in web console settings.URLs