Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track product click events in glean.js #14416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Apr 5, 2024

One-line summary

  • Updates to Glean.js v5.0.1.
  • Removes older custom click event and switches to the new standardized Glean event.
  • Tracks click events for Firefox and VPN CTA links.

Significant changes and points to review

Glean is only enabled on dev right now, so this should be safe to test out.

Issue / Bugzilla link

N/A

Testing

  • make preflight
  • npm start
  • Set window.Glean.setLogPings(true) in the web console and refresh the page to view raw ping logs as you click element in a page.
  • You might also want to enable Persist Logs in web console settings.

URLs

@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Apr 5, 2024
@alexgibson alexgibson force-pushed the glean-click-events branch 4 times, most recently from 76fc66d to 5434a0e Compare April 10, 2024 08:19
@alexgibson alexgibson force-pushed the glean-click-events branch 3 times, most recently from 7ada199 to ef426e9 Compare April 23, 2024 14:46
@stephaniehobson stephaniehobson self-requested a review April 30, 2024 19:44
@stephaniehobson stephaniehobson self-assigned this Apr 30, 2024
@alexgibson
Copy link
Member Author

@stephaniehobson I'm going to set this one back to draft until the consent banner PR has merged. Will revisit, thanks.

@alexgibson alexgibson marked this pull request as draft May 22, 2024 08:09
@alexgibson alexgibson force-pushed the glean-click-events branch 2 times, most recently from 25dee02 to 61fd001 Compare May 31, 2024 08:30
@alexgibson alexgibson force-pushed the glean-click-events branch 5 times, most recently from 6dc7d5f to d22e015 Compare June 4, 2024 09:16
@alexgibson alexgibson marked this pull request as ready for review June 4, 2024 09:20
@alexgibson
Copy link
Member Author

alexgibson commented Jun 4, 2024

@stephaniehobson this is now rebased and ready for review, thanks.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.87%. Comparing base (17adeb7) to head (d22e015).

Current head d22e015 differs from pull request most recent head 71125e4

Please upload reports for the commit 71125e4 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14416      +/-   ##
==========================================
- Coverage   76.94%   76.87%   -0.07%     
==========================================
  Files         157      156       -1     
  Lines        8192     8157      -35     
==========================================
- Hits         6303     6271      -32     
+ Misses       1889     1886       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants