Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some docs for the privacy notice templates #14233 #14562

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

stephaniehobson
Copy link
Contributor

One-line summary

Add some docs for the privacy notice templates.

Significant changes and points to review

  • added file
  • added link to file

Issue / Bugzilla link

This is to help with #14233

Testing

make livedocs in your venv

@stephaniehobson stephaniehobson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.45%. Comparing base (c9999ed) to head (055d325).
Report is 35 commits behind head on main.

Current head 055d325 differs from pull request most recent head d432f6e

Please upload reports for the commit d432f6e to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14562   +/-   ##
=======================================
  Coverage   76.45%   76.45%           
=======================================
  Files         148      148           
  Lines        7979     7979           
=======================================
  Hits         6100     6100           
  Misses       1879     1879           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits: one typo and the rest is just formatting/Qs:

docs/legal-docs.rst Outdated Show resolved Hide resolved
docs/legal-docs.rst Outdated Show resolved Hide resolved
docs/legal-docs.rst Outdated Show resolved Hide resolved
docs/legal-docs.rst Outdated Show resolved Hide resolved

### Footnote {: footnote }

If a section contains a heading with an ID of `footnote` the section will be extracted and output as the last thing on the page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: any heading or an h3 specifically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any heading.

stephaniehobson and others added 4 commits May 21, 2024 10:54
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
@stephaniehobson
Copy link
Contributor Author

Committed all of @janbrasna's excellent review suggestions. I'll look for someone to hit the green button.

Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📜

@craigcook craigcook merged commit 7030e72 into main May 21, 2024
3 checks passed
@craigcook craigcook deleted the legal-docs branch May 21, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants