-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some docs for the privacy notice templates #14233 #14562
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14562 +/- ##
=======================================
Coverage 76.45% 76.45%
=======================================
Files 148 148
Lines 7979 7979
=======================================
Hits 6100 6100
Misses 1879 1879 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits: one typo and the rest is just formatting/Qs:
|
||
### Footnote {: footnote } | ||
|
||
If a section contains a heading with an ID of `footnote` the section will be extracted and output as the last thing on the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: any heading or an h3 specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any heading.
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
Co-authored-by: Jan Brasna <1784648+janbrasna@users.noreply.github.com>
Committed all of @janbrasna's excellent review suggestions. I'll look for someone to hit the green button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📜
One-line summary
Add some docs for the privacy notice templates.
Significant changes and points to review
Issue / Bugzilla link
This is to help with #14233
Testing
make livedocs
in your venv