TEST: update to clap 4.0.0-prerelease #316
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
commented
Aug 27, 2022
| @@ -3,17 +3,47 @@ source: tests/test-cli.rs | |||
| expression: format_outputs(&output) | |||
| --- | |||
| stdout: | |||
| cargo-vet 0.3.0 | |||
| cargo-vet-vet 0.3.0 | |||
There was a problem hiding this comment.
This is a regression, unclear whose fault it is (see clap-rs/clap#4132 (comment)).
There was a problem hiding this comment.
If you set name = cargo in addition to the bin_name, this should be resolved. See https://github.com/clap-rs/clap/blob/master/examples/cargo-example-derive.rs#L4
In clap 3, the user sets bin_name = cargo and we build that up as we recurse down the subcommands. When we then render the "name", we then did a search/replace on it which on windows without an explicit bin_name would end up with foo.exe-bar. So in clap 4, we build up the usage_name from the root command's bin_name + each subcommand's name and the display_name from all command's names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a demo for clap-rs/clap#4132