Perform import validation when aggregating remote audit files #586
+62
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afranchuk
approved these changes
Jan 8, 2024
mystor
force-pushed
the
validate_aggregate
branch
from
8e80aad
to
919f854
Compare
|
The clippy lint failures will be fixed in #596 |
mystor
force-pushed
the
validate_aggregate
branch
from
919f854
to
f2bba00
Compare
This copies the behaviour from normal imports, meaning that it handles things like version mismatches gracefully, and only emits a warning that those audits were ignored. We may want to include an option to make this more aggressive, as aggregate is expected to be frequently run in automation so warnings may be invisible.
mystor
force-pushed
the
validate_aggregate
branch
from
f2bba00
to
de19fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the behaviour from normal imports, meaning that it handles things like version mismatches gracefully, and only emits a warning that those audits were ignored.
We may want to include an option to make this more aggressive, as aggregate is expected to be frequently run in automation so warnings may be invisible.