Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cargo-dist to generate releases #600

Merged
merged 2 commits into from May 20, 2024
Merged

Conversation

staktrace
Copy link
Contributor

This PR was generated by running cargo dist init and selecting all the default options. It seems to have pretty sane behaviour out of the box.

This requires the repository URL fix in #599 to work correctly.

Fixes #484

This PR was generated by running `cargo dist init` and selecting
all the default options. It seems to have pretty sane behaviour
out of the box.

This requires the repository URL fix in mozilla#599
to work correctly.

Fixes mozilla#484
This was causing spurious test failures, since the cargo dist
setup introduced a workspace that automatically included the
test project.
@staktrace
Copy link
Contributor Author

Copy link
Collaborator

@bholley bholley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only skimmed the logic but I understand this is vanilla output from cargo-dist, which was built by the same person who built the initial version of cargo-vet.

@bholley bholley merged commit ac9a882 into mozilla:main May 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish pre-built binaries of cargo-vet
2 participants