-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logical-assignment error handling #212
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -243,6 +243,19 @@ RuleHelper.prototype = { | |
normalizeMethodCall(node) { | ||
let methodName; | ||
let objectName; | ||
|
||
// operators that allow us to only inspect the right side of the assignment: | ||
const RIGHT_OPERATORS = ["="]; | ||
|
||
// operators where we can skip analysis: | ||
// e.g., there's no point in doing a check if | ||
// this ends up doing a mathematical operation. The result is not going to be a callable | ||
const MATH_OPERATORS = ["+=", "-=", "*=", "/=", "%=", "**=", "<<=", ">>=", | ||
">>>=", "&=", "|=", "^="]; | ||
|
||
// operators where we don"t know the result of a logical expression, which may result in the code executing the left or the right part of the assignmentcan check the left bit: | ||
const LOGICAL_OPERATOS = ["||=", "&&=", "??="]; | ||
|
||
switch (node.type) { | ||
case "Identifier": | ||
methodName = node.name; | ||
|
@@ -256,6 +269,22 @@ RuleHelper.prototype = { | |
case "ArrowFunctionExpression": | ||
methodName = ""; | ||
break; | ||
case "AssignmentExpression": | ||
if (RIGHT_OPERATORS.includes(node.operator)) { | ||
methodName = this.normalizeMethodCall(node.right); | ||
} else if (MATH_OPERATORS.includes(node.operator)) { | ||
methodName = ""; | ||
break; | ||
} else if (LOGICAL_OPERATOS.includes(node.operator)) { | ||
// Issue #210: oh, no! we have two methods names we need to check, but this function | ||
// may only return one. it's not immediately clear how to reconcile that with existing callers of normalizeMethodCall. | ||
methodName = ""; | ||
Comment on lines
+279
to
+281
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
how about changing this method to return an array of method names and on the caller side to expect an array to be always returned and iterate on that array to check all method names returned? |
||
} | ||
else { | ||
// this is the forcing function for us to complain about and implement support if new JS operators come up. | ||
this.reportUnsupported(node, "Unexpected callable", `unexpected assignment with operator '${node.operator}' in normalizeMethodCall`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thought: I think that we may be able to cover this branch with a test case using that |
||
} | ||
break; | ||
case "Import": | ||
methodName = "import"; | ||
break; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: OPERATOS => OPERATORS