Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset importer problems #338

Open
AmitMY opened this issue Jan 8, 2024 · 0 comments · May be fixed by #342
Open

Dataset importer problems #338

AmitMY opened this issue Jan 8, 2024 · 0 comments · May be fixed by #342

Comments

@AmitMY
Copy link
Contributor

AmitMY commented Jan 8, 2024

The dataset importer introduced a couple months ago has two issues:

  1. https://github.com/mozilla/firefox-translations-training/blob/main/Snakefile#L281 calls it using bash, not python (then the errors are related to bash not recognizing "import" etc)
  2. ValueError: Invalid dataset name: custom-corpus_/corpora/parallel/test/all. Use the following format: <importer>_<name> or <importer>_<augmentation>_<name>. This is because the regex checked doesn't allow for dashes. The correct regex is ^([\w-]*)_(aug[a-z\-]*)?_?(.+)$

(with these two fixes, the pipeline continues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants