Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Dataset importer problems #342

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix Dataset importer problems #342

wants to merge 4 commits into from

Conversation

AmitMY
Copy link
Contributor

@AmitMY AmitMY commented Jan 9, 2024

fix #338

gregtatum
gregtatum approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@gregtatum
Copy link
Member

Oh wait, the tests aren't passing. We should investigate that before merging.

gregtatum
gregtatum requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is causing real test failures. I'm requesting changes since I believe this is breaking things.

sacreBLEU: Unknown test set 'aug-mix_wmt19'

@AmitMY
Copy link
Contributor Author

AmitMY commented Jan 11, 2024

Seems like _ is a word character (\w), let's try with it optional. We'll see if there's another issue in the tests

gregtatum
gregtatum approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good! Let's wait until #362 merges, then I can rebase and merge. Thanks for the fix.

gregtatum
gregtatum requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like CI is still failing here.

@AmitMY
Copy link
Contributor Author

AmitMY commented Jan 30, 2024

It did pass before you merged master again, iirc

@gregtatum
Copy link
Member

There is a red X next to your previous pushes, see: https://github.com/mozilla/firefox-translations-training/runs/20456494808

That looks like an intermittent failure, but it never got to the eval steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregtatum gregtatum gregtatum requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset importer problems
2 participants
@AmitMY @gregtatum