Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Taskcluster task naming #589

Merged
merged 7 commits into from
May 16, 2024
Merged

Conversation

vrigal
Copy link
Contributor

@vrigal vrigal commented May 13, 2024

Required by #519 (making build_task_name supports evaluation tasks labels tags from Taskcluster)

Closes #573

@vrigal vrigal marked this pull request as ready for review May 14, 2024 08:50
Copy link
Collaborator

@eu9ene eu9ene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but let's discuss if we want to implement support of renaming from #544 right away.

tracking/translations_parser/utils.py Outdated Show resolved Hide resolved
@vrigal vrigal closed this May 15, 2024
@vrigal vrigal reopened this May 15, 2024
Copy link
Collaborator

@eu9ene eu9ene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrigal Do I understand correctly that now a suffix -1 is added to all the runs? If yes, we do not want that. We train multiple models only for the teacher. This -1 makes names longer. To be more explicit, we want:

(for older models)
teacher-base-0
teacher-base-1
teacher-parallel-0
teacher-parallel-1
teacher-all-0
teacher-all-1
finetune-teacher-1
finetune-teacher-2
etc.

(for newer Taskcluster models)
teacher-1
teacher-2
backwards
student
student-finetuned
quantized
teacher-ensemble

Naming of the teacher models will differ for the older experiments but everything else should be exactly the same across all the experiments and publishers. We might want to store a map of renamings.

@vrigal
Copy link
Contributor Author

vrigal commented May 16, 2024

@eu9ene I pushed a commit trying to match your example.

Custom renaming could be a follow-up of this I suppose.

Copy link
Collaborator

@eu9ene eu9ene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see the values in unit tests but to verify this we would need to reupload everything from scratch. We can do that in #574

@eu9ene eu9ene merged commit c3ad3a4 into mozilla:main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure naming for runs is consistent
2 participants