Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GHA CI #432

Merged
merged 3 commits into from
Jan 8, 2021
Merged

add GHA CI #432

merged 3 commits into from
Jan 8, 2021

Conversation

g-k
Copy link
Contributor

@g-k g-k commented Jan 8, 2021

refs: #429

Migrate CI to github actions

NB: test w/ python 3.9 fails due to a dep build failure, but I think that's fine for now and we can not require it to pass to merge

NB: there are third party actions for publish GH pages we could try too (pending GH admin approval)

I don't have a way to test the publish actions. I'm least certain about the gh-pages action in particular.

  • generate and add new pypi creds to the workflow config
  • generate and add a new GH token with repo scope to the workflow config (edit: ended up generating a new deploy SSH key)
  • update the required jobs in branch protection settings
  • tag a commit to test the publish workflow
  • remove the travis CI config; update badges (separate PR)

r? @ajvb @hwine

@g-k g-k marked this pull request as ready for review January 8, 2021 18:03
@g-k g-k requested review from ajvb and hwine January 8, 2021 18:04
@g-k g-k changed the title migrate CI add GHA CI Jan 8, 2021
Copy link
Contributor

@ajvb ajvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you Greg!

.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@hwine hwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit

As for testing gh-pages publishing, I did that previously using a fork in my personal account. That wasn't "easy" (lots of configuration points), so I'd suggest that route only if there are problems.

I believe the way to test pypi publishing is via the pypi staging/test server, but have no experience with that.

.github/workflows/test.yml Show resolved Hide resolved
@g-k g-k merged commit 1c34416 into master Jan 8, 2021
@g-k g-k deleted the fix-429-migrate-ci branch January 8, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants