Add clearer tracker removal breakage warnings #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloan
approved these changes
Aug 4, 2022
| # This is displayed in small under a number in a large font indicating the number of trackers that have been removed from all emails sent to a particular mask | ||
| profile-label-trackers-removed = Trackers removed | ||
| profile-trackers-removed-tooltip-part1 = With tracker removal enabled, common email trackers will be removed from your forwarded emails. | ||
| profile-trackers-removed-tooltip-part2 = Important: Sometimes removing trackers may cause your email to look broken, because the trackers are often contained within images. | ||
| profile-trackers-removed-tooltip-part2-2 = <b>Important:</b> Removing trackers may cause your email to look broken, because the trackers are often contained within images and links. |
There was a problem hiding this comment.
non-blocking: This is new to me - I did not know we could include html within strings.
There was a problem hiding this comment.
Yeah, it's kinda cumbersome at the moment since you can't use the useString hook - you'll need to use <Localized>. (Incidentally, I have a pull request open on @fluent/react to provide a similar hook API for it.) It's also not exactly HTML; I could've used anything tag-like here (e.g. <notice>Important:</notice>, and then in the elems attribute of <Localized> you can provide a mapping of that to actual tags.
codemist
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes MPP-2248. The news announcement
will also need an update, but I haven't received that string yethas been updated as well.How to test: look at the locations I screenshotted in the l10n PR - the text should be updated to mention trackers in images and links, and about how broken emails can't be recovered.
/frontend/src/styles/tokens.scss).