Bug 1617528 - Enable modernize-use-using at review phase r=andi

Differential Revision: https://phabricator.services.mozilla.com/D63819 --HG-- extra : moz-landing-system : lando
mozilla · Feb 24, 2020 · 205bea2 · 205bea2
1 parent f2ed03b
commit 205bea2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/tools/clang-tidy/config.yaml b/tools/clang-tidy/config.yaml
@@ -173,6 +173,8 @@ clang_checkers:
     reliability: low
     # Too noisy because of the way how we implement NS_IMETHOD. See Bug 1420366.
     publish: !!bool no
+  - name: modernize-use-using
+    reliability: high
   - name: mozilla-*
     reliability: high
   - name: performance-faster-string-find

diff --git a/tools/clang-tidy/test/modernize-use-using.cpp b/tools/clang-tidy/test/modernize-use-using.cpp
@@ -0,0 +1,6 @@
+template <typename T>
+class Test {
+  typedef typename T::iterator Iter;
+};
+typedef int Type;
+
diff --git a/tools/clang-tidy/test/modernize-use-using.json b/tools/clang-tidy/test/modernize-use-using.json
@@ -0,0 +1 @@
+[["warning", "use 'using' instead of 'typedef'", "modernize-use-using"], ["warning", "use 'using' instead of 'typedef'", "modernize-use-using"], {"reliability": "high"}]