Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1867821 - Implement an uploader that defaults to sendBeacon and falls back to… #1866

Merged
merged 3 commits into from Feb 1, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Jan 30, 2024

First try at this to get it going, see inline comments for questions.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from rosahbruno January 30, 2024 12:18
@badboy badboy force-pushed the 1867821/sendbeacon-fallback-uploader branch from 81ee605 to 755d762 Compare January 30, 2024 12:49
@badboy badboy force-pushed the 1867821/sendbeacon-fallback-uploader branch from 755d762 to 3a2e59e Compare January 31, 2024 09:33
Copy link
Contributor

@rosahbruno rosahbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will file the follow up bug discussed offline and in previous comments.

@rosahbruno rosahbruno merged commit b1404d0 into main Feb 1, 2024
7 checks passed
@rosahbruno
Copy link
Contributor

@badboy
Would you mind making a follow up PR to this with a changelog entry? We don't need to be too descriptive since I am going to create a google doc with info about the uploaders.

@badboy badboy deleted the 1867821/sendbeacon-fallback-uploader branch February 2, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants