Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix m1 npm ci fail by replacing lib-hubs with three-particle-emitter #5621

Closed
wants to merge 1 commit into from

Conversation

kenykhung
Copy link

Related to discussion #5603
Replace lib-hubs with three-particle-emitter to bypass legacy electron dependency and pass npm ci for mac m1

Tested environment:
Mac M1 Pro 12.1
NPM 8.1.2
Node v16.15.0

@netpro2k
Copy link
Contributor

netpro2k commented Aug 1, 2022

Hmm. This unfortunately ends up using an outdated version of three-particle-emitter (since the changes we made in lib-hubs haven't been published). We can probably publish a new version but I would like to try and actually get to the bottom of what is importing electron and just fix that instead...

@camelgod
Copy link

I just copy-pasted the lib-hubs .js files into hubs repo and reference it locally for now. Works fine! Will do that until Mozilla can clean up lib-hubs dependency issues.

@knev
Copy link

knev commented Sep 5, 2022

@camelgod I don't suppose you could elaborate on that workaround. I found lib-hubs. Where do i need to make the local changes exactly?

@markusTraber
Copy link
Contributor

As a workaround, I am using rosetta.
Here are some instructions for it: https://github.com/nvm-sh/nvm#macos-troubleshooting

You might need to manually delete previously installed node versions for arm64.

@wswoodruff
Copy link

wswoodruff commented Nov 18, 2022

Can confirm that installing rosetta using the following steps fixed being able to npm ci on M1 for me

$ softwareupdate --install-rosetta
(Follow through agreement or whatever)

$ arch -x86_64 zsh
(Gives a new shell)

Uninstall node 16.16.0

Reinstall node 16.16.0

(Running npm ci now unlocked on all system shells 🎉)
$ npm ci

(Run for admin too, and dialog if u use it)
$ cd admin && npm ci

@keianhzo
Copy link
Contributor

This other PR should fix this: MozillaReality/lib-hubs#46

Closing for now.

@keianhzo keianhzo closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants