Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: EnvironmentMap not updating after changing scene #6041

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

angelcabrera-nr
Copy link

@angelcabrera-nr angelcabrera-nr commented Apr 18, 2023

When changing the scene of a room, the Environment Map (skybox component) is not updating correctly. The environment map remains with the configuration of the previous scene

I also found this comment in the Skybox component:
// TODO if we care about dynamic skybox changes we should also update the environment map here

What is just the solution to the problem I was having.

Light Scene example:

Original Scene Lighting/Colors:

image

Scene colors and lights when coming from a dark scene:

image

Dark scene example:

Original Scene Lighting/Colors:

image

Scene colors and lights when coming from a light scene:

image

How to reproduce:

Create two scenes:

  • A Scene with a dark Skybox:

Example:
image

  • Another scene with a Light Skybox:

Example:
image

Then create a room with one of the scenes and inside the room change to the other scene, you will notice that the new scene you have loaded looks with the brightness of the previous scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant