Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes error in chat commmad permission checking #6093

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pattersonbl2
Copy link
Contributor

Removes this.hubChannel.signIn due to improper function use.

The function will always return true in the if statement, which doesn't validate user sign-in permission.

Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants