Add a way to move camera infinitely (add pointerlock) #6181
+101
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that the mouse functionality is unusable with a three-monitor setup. Even with just one monitor, I still find it annoying to use as the mouse can hit the screen corner.
closes #1352
And I also refactored code a bit so it easier to read.
I decided to not enable new functionality by default (as it has problem that you can see on gif).
When pointerlock gets released cursor position is misleading and it gets updated after mousemove event. I think the proper solution would be to change cursor behavior so it stays on the same place and arrow indicates moving direction instead.
GIF