New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-ons support #6468
Draft
keianhzo
wants to merge
29
commits into
master
Choose a base branch
from
addons
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add-ons support #6468
+2,614
−617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
force-pushed
the
addons
branch
2 times, most recently
from
February 15, 2024 10:28
b2d9ae7
to
5ee0ba8
Compare
hrithikwins
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Add-ons in Hubs. For some background, see here: #6099
You can find the Hubs TS typings here (WIP): https://github.com/MozillaReality/hubs-ts-types
A template to simplify add-on development: https://github.com/MozillaReality/hubs-template-addon
There are also a couple demo add-on:
Duck add-on. This was previously part of the client code but in this branch has been converted to an add-on: https://github.com/MozillaReality/hubs-duck-addon
Portals add-on. A simple portals implementation as an add-on to illustrate a more complex Hubs add-on:
https://github.com/MozillaReality/hubs-portals-addon
To add add-ons to a client:
addons.json
file.