Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Wagtail and Wagtail-Localize #5994

Merged
merged 4 commits into from
May 31, 2024

Conversation

escattone
Copy link
Contributor

@escattone escattone commented May 6, 2024

mozilla/sumo#1681

Notes

  • This lays the foundation for all of our following Wagtail and Wagtail-Localize work.
  • The model changes and associated database migrations are necessary to avoid related_name clashes with Wagtail.
  • The Wagtail admin is rendered properly and its UI will be localized with the user's preferred locale. Currently the user's preferred locale must be specified in the user's Wagtail account profile, but as @smithellis noted, we need to decide what we want to do with the Wagtail profile in light of the SuMO profile.
  • The Wagtail admin is temporarily behind LDAP.
  • Jinja2 templates play nicely with Django templates and both work with Wagtail.
  • This PR also provides the ability to conditionally serve Wagtail pages from the /{locale}/wagtail/ root URL. Wagtail pages are served from that root URL only if the wagtail_experiments Waffle flag exists and is active for the given request.

@escattone escattone changed the title Introduce wagtail 1681 Introduce Wagtail and Wagtail-Localize May 8, 2024
@escattone escattone marked this pull request as ready for review May 20, 2024 15:45
@escattone escattone force-pushed the introduce-wagtail-1681 branch 2 times, most recently from e6606ff to 107a484 Compare May 20, 2024 21:05
@akatsoulas
Copy link
Collaborator

@escattone overall this looks good. Please re-arrange a bit the commits in a way that can be reversible and group functionality per context (eg installation and initial configuration, waffle, class conflicts, customized login etc) and I will have one final pass.

@escattone escattone requested review from smithellis and removed request for smithellis May 30, 2024 19:51
@escattone
Copy link
Contributor Author

@akatsoulas I re-organized the commits, and it's ready for another review.

Copy link
Collaborator

@akatsoulas akatsoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @escattone 🚀

@escattone escattone merged commit a8ddd5d into mozilla:main May 31, 2024
2 checks passed
@escattone escattone deleted the introduce-wagtail-1681 branch May 31, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants