Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .circleci/config.yml #9

Merged
merged 19 commits into from
May 22, 2024
Merged

Add .circleci/config.yml #9

merged 19 commits into from
May 22, 2024

Conversation

chelseatroy
Copy link
Collaborator

@chelseatroy chelseatroy commented May 13, 2024

Goal(s) of this Pull Request:

  • Get started on CircleCI in our repository! This CircleCI build:
  1. installs dependencies (with caching for speed)
  2. Runs the unit tests
  3. Runs the linter

@Dexterp37 getting integration tests to work here is possible but more involved, requiring collaboration with SRE to get a service account to reference in the build. So I'm making that a separate ticket.

Acceptance criteria:

In order to approve, reviewer must be able to...

  • When one opens a new branch, the CircleCI script should run there.

Copy link
Collaborator

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work. Solid starting point, I'd love to see us enable the the formatting check (since we have that available) so that we catch these problems too before merge.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
command: "poetry run pytest"
- run:
name: "Format check"
command: "poetry run ruff check"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add the format check as well? Should be poetry run ruff format --check (see here)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

- run:
name: "Format check"
command: "poetry run ruff check"
# - run:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a reference to the ticket for working on this :) e.g. something like "# To be addressed in XXX"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

chelseatroy and others added 3 commits May 15, 2024 14:29
Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
Copy link
Collaborator

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection! :shipit:

@chelseatroy chelseatroy merged commit 68d7786 into main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants