-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .circleci/config.yml #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work. Solid starting point, I'd love to see us enable the the formatting check (since we have that available) so that we catch these problems too before merge.
command: "poetry run pytest" | ||
- run: | ||
name: "Format check" | ||
command: "poetry run ruff check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please add the format check as well? Should be poetry run ruff format --check
(see here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
- run: | ||
name: "Format check" | ||
command: "poetry run ruff check" | ||
# - run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a reference to the ticket for working on this :) e.g. something like "# To be addressed in XXX"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfection!
Goal(s) of this Pull Request:
@Dexterp37 getting integration tests to work here is possible but more involved, requiring collaboration with SRE to get a service account to reference in the build. So I'm making that a separate ticket.
Acceptance criteria:
In order to approve, reviewer must be able to...