Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(transport): maximum throughput on unlimited bandwidth and 50ms #1857

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(transport): maximum throughput on unlimited bandwidth and 50ms #1857

wants to merge 1 commit into from
+41 −1

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Apr 25, 2024

This commit adds a basic smoke test using the test-fixture simulator, asserting that on a connection with unlimited bandwidth and 50ms round-trip-time Neqo can eventually achieve > 1 Gbit/s throughput.

Showcases the potential that a future stream flow-control auto-tuning algorithm can have.

See #733.

Draft for now. Not familiar enough with the simulator yet. Will be helpful for an implementation of #733.

As expected, test is currently failing. I can not quite yet explain the value of 106 Mbit/s. I would expect a value closer to 160 Mbit/s given the 1 MiB send and receive stream buffer. (See calculation in #1820.)

thread 'unlimited_bandwidth_50ms_delay_connection' panicked at neqo-transport/tests/network.rs:227:5:
expect transfer on 50ms connection with unlimited bandwidth to eventually surpass 1 Gbit/s but got 106.41665660578931 Mbit/s.

@mxinden
test(transport): maximum throughput on unlimited bandwidth and 50ms
c0a72ce 
This commit adds a basic smoke test using the `test-ficture` simulator,
asserting that on a connection with unlimited bandwidth and 50ms round-trip-time
Neqo can eventually achieve > 1 Gbit/s throughput.

Showcases the potential a future stream flow-control auto-tuning algorithm can have.

See mozilla#733.
@github-actions GitHub Actions
Copy link

Failed Interop Tests

Succeeded and unsupported tests

Succeeded Interop Tests

Unsupported Interop Tests

@mxinden mxinden mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang will be requested when the pull request is marked ready for review KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson will be requested when the pull request is marked ready for review martinthomson is a code owner

@larseggert larseggert Awaiting requested review from larseggert larseggert will be requested when the pull request is marked ready for review larseggert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mxinden