Feat switch to jest

[madarche]

Switch to Jest

[coveralls]

Coverage decreased (-5.3%) to 93.37% when pulling 5b576c8 on madarche:feat-switch-to-jest into 0638485 on mozilla:master.

[coveralls]

Coverage decreased (-5.3%) to 93.37% when pulling 5b576c8 on madarche:feat-switch-to-jest into 0638485 on mozilla:master.

[A-312]

🤔

[A-312]

I thought you refuse mocha because of the syntax expect(variable).to.be.something 😕

[madarche]

@A-312 I was convinced of the interest to switch from js-must. But should.js and chai.js were not good candidates because they both allow the use of property access for assertions cf. https://github.com/moll/js-must/#asserting-on-property-access. Chai.js documents the following as recommended expect(true).to.be.true; // Recommended cf. https://www.chaijs.com/api/bdd/ which is something we don't want to creep in Convict. And the good candidate also had to not (ab)use prototype. See also nodejs/node#32279. In the end there is only Jest that fits.

EDIT: Of course I should have mentioned Node TAP, which is secure and well designed, that I also considered. But Jest's matchers are more human readable at first glance than TAP's assertions.

[A-312]

I read a new time and I understand now: expect(true).to.be.will_be_wrong_but_dont_throw; 😕 This is not a good thing :(

EDIT: They use proxy on their object to avoid this error

I tried:

            }
          }
        }
      }

      conf.validate()

      expect(conf.has('default')).to.be.lol
      expect(conf.getSchemaString()).to.equal(JSON.stringify(expected, null, 2))
      expect(conf.getSchemaString(true)).to.equal(JSON.stringify(nodeSchemaExpected, null, 2))
    })
  })

Seem fine:

  1) blueconfig get function
       .get()
         must parse with custom default substitute:
     Error: Invalid Chai property: lol. Did you mean "to"?
      at Object.proxyGetter [as get] (packages\blueconfig\node_modules\chai\lib\chai\utils\proxify.js:75:17)
      at Context.<anonymous> (packages\blueconfig\test\get-tests.js:133:40)
      at processImmediate (internal/timers.js:456:21)

I'm not sure to understand the 2nd argument.