cleaned up as per review by @gijsk

mozilla · Jun 15, 2017 · dbb2b5a · dbb2b5a
1 parent 4a222ab
commit dbb2b5a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/recipe-client-addon/lib/NormandyDriver.jsm b/recipe-client-addon/lib/NormandyDriver.jsm
@@ -168,7 +168,7 @@ this.NormandyDriver = function(sandboxManager) {
         onInstallFailed(addonInstall) {
           reject(`AddonInstall error code: [${addonInstall.error}]`);
         },
-        onDownloadFailed(install) {
+        onDownloadFailed() {
           reject(`Download failed: [${installUrl}]`);
         },
       }));

diff --git a/recipe-client-addon/test/browser/browser_NormandyDriver.js b/recipe-client-addon/test/browser/browser_NormandyDriver.js
@@ -32,19 +32,17 @@ add_task(withDriver(Assert, async function installXpi(driver) {
 }));
 
 add_task(withDriver(Assert, async function uninstallInvalidAddonId(driver) {
-  // Test that we can install an XPI from any URL
   const invalidAddonId = "not_a_valid_xpi_id@foo.bar";
   try {
     await driver.uninstallAddon(invalidAddonId);
-    ok(false, `Uninstall returned an unexpected null for success`);
+    ok(false, `Uninstalling an invalid XPI should fail.  uninstallAddon resolved successfully though.`);
   } catch (e) {
     ok(true, `This is the expected failure`);
   }
 }));
 
 
 add_task(withDriver(Assert, async function installXpiBadURL(driver) {
-  // Test that we can install an XPI from any URL
   const xpiUrl = "file:///tmp/invalid_xpi.xpi";
   try {
     await driver.installAddon(xpiUrl);