Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial version of an install and uninstall hook #778

Merged
merged 12 commits into from
Jun 16, 2017
Merged

initial version of an install and uninstall hook #778

merged 12 commits into from
Jun 16, 2017

Commits on Jun 15, 2017

  1. initial version of an install and uninstall hook

    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    38c4e76 View commit details
    Browse the repository at this point in the history

  2. Generate file:// URI for test XPI in test instead of handling chrome://.

    @crankycoder
    Michael Kelly authored and crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    a047c88 View commit details
    Browse the repository at this point in the history

  3. dropped leftover debug message in test case

    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    3d76fa4 View commit details
    Browse the repository at this point in the history

  4. Inlined some functions as per code review and added more assertions i… 

    …nto the testcase to verify that the addon was properly installed by checking the value of the addonId
    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    43ea147 View commit details
    Browse the repository at this point in the history

  5. Cleanup brackets

    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    2e0006a View commit details
    Browse the repository at this point in the history

  6. Replaced named function with an immediately invoked function to creat… 

    …e the closure around the Promise that wraps AddonManager.getAddonByID
    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    46c1612 View commit details
    Browse the repository at this point in the history

  7. signed the normandy.xpi file

    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    3133ba0 View commit details
    Browse the repository at this point in the history

  8. * reworked the installAddon api to use async functions as per code re… 

    …view

* Reordered the listener and install() invocation to avoid possible race
* double check the addonID after installation
* added a timeout to let the XPI installation complete properly.
    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    ff13dad View commit details
    Browse the repository at this point in the history

  9. Added a testcase and missing capture of the onDownloadFailed event wh… 

    …en installing an addon

added testcase to uninstall invalid addon id
    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    0e42728 View commit details
    Browse the repository at this point in the history

  10. wrapped functions with sandboxmanager.wrapAsync 

    dropped "return null"
    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    2bedd04 View commit details
    Browse the repository at this point in the history

  11. Add missing return and refactor tests.

    @crankycoder
    Michael Kelly authored and crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    4a222ab View commit details
    Browse the repository at this point in the history

  12. cleaned up as per review by @gijsk

    @crankycoder
    crankycoder committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    dbb2b5a View commit details
    Browse the repository at this point in the history