Move canvas to optionalDependencies #15655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stalling pdfjs-dist even if the installation of canvas fails. Close mozilla#15652
Snuffleupagus
approved these changes
Nov 2, 2022
|
Any ETA on new release for this fix? |
|
+1 above |
|
@Snuffleupagus when will be release? |
|
This will be included in the next release which, provided that nothing unforeseen happens[1], is planned for the end of the month. [1] Please keep in mind that the releases, in addition to many things in this project, are handled by unpaid contributors. |
|
Fixed in release 3.1.81. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
canvastooptionalDependencies, which enables npm to continue installingpdfjs-disteven if the installation ofcanvasfails. Close #15652.