Use fuzzy-matching to improve cache hit rates with PostScriptEvaluator
#18070
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
PostScriptEvaluator-fuzzy-cache
branch
2 times, most recently
from
952b07d
to
b354b3a
Compare
This improves performance, without any noticeable regressions when running `gulp browsertest --noChrome` locally on Windows. Testing the new `pr5134` test-case locally in the viewer: - With the `master` branch and `isEvalSupported = true`, page 2 renders in approx. 350 milliseconds. - With the `master` branch and `isEvalSupported = false`, page 2 renders in approx. 1550 milliseconds. - With this patch and `isEvalSupported = false`, page 2 renders in approx. 700 milliseconds. Hence this obviously isn't enough to close the performance gap, but it *may* still be helpful.
Snuffleupagus
force-pushed
the
PostScriptEvaluator-fuzzy-cache
branch
from
b354b3a
to
ec6b346
Compare
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/382315f0624ec58/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4cdbf6b9625ca96/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/382315f0624ec58/output.txt Total script time: 44.16 mins
Image differences available at: http://54.193.163.58:8877/382315f0624ec58/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4cdbf6b9625ca96/output.txt Total script time: 51.56 mins
Image differences available at: http://54.241.84.105:8877/4cdbf6b9625ca96/reftest-analyzer.html#web=eq.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance, without any noticeable regressions when running
gulp browsertest --noChromelocally on Windows.Testing the new
pr5134test-case locally in the viewer:masterbranch andisEvalSupported = true, page 2 renders in approx. 350 milliseconds.masterbranch andisEvalSupported = false, page 2 renders in approx. 1550 milliseconds.isEvalSupported = false, page 2 renders in approx. 700 milliseconds.Hence this obviously isn't enough to close the performance gap, but it may still be helpful.