Fix an off-by-1 error in section lookup #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takikawa
force-pushed
the
fix-section-lookup-off-by-one
branch
2 times, most recently
from
27daf1a
to
86db47b
Compare
bomsy
reviewed
May 28, 2024
bomsy
reviewed
May 28, 2024
bomsy
requested changes
May 28, 2024
takikawa
force-pushed
the
fix-section-lookup-off-by-one
branch
from
86db47b
to
3789341
Compare
Thanks for the suggestions! I've updated the patch now. |
bomsy
approved these changes
May 28, 2024
In an indexed map, the offset line & column are stored 1-based. However, the lookup for originalPositionFor was not incrementing the 0-based column from the API argument.
takikawa
force-pushed
the
fix-section-lookup-off-by-one
branch
from
3789341
to
79aa958
Compare
|
There was a linter failure in CI, but should be fixed now (looks like the CI might need approval again to run). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #506.