Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1600752 - Accessibility improvements Compare and Alert Views #5733

Merged
merged 8 commits into from Dec 19, 2019
Merged

Bug 1600752 - Accessibility improvements Compare and Alert Views #5733

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b330332
Bug 1600752 - Compare View Changes
yogmel Dec 6, 2019
4b2d7e5
Bug 1600752 - Alerts View Change
yogmel Dec 9, 2019
1b022b4
Bug 1600752 - Remove eslint directive
yogmel Dec 9, 2019
899fe22
Bug 1600752 - changes based on feedback
yogmel Dec 11, 2019
0331ea5
Bug 1600752 - changes based on feedback: TruncatedText button style
yogmel Dec 16, 2019
fffb79f
Bug 1600752 - changes based on feedback - TruncatedText and focus link
yogmel Dec 17, 2019
cba10de
Bug 1600752 - changes based on feedback: TruncatedText button style
yogmel Dec 18, 2019
2e5b5a3
Bug 1600752 - changes based on feedback: TruncatedText button style 2
yogmel Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/perfherder/alerts/AlertTable.jsx
View file
Open in desktop
Expand Up @@ -307,10 +307,10 @@ export default class AlertTable extends React.Component {
{alertSummary.notes && (
<div className="bg-white px-3 py-4">
<TruncatedText
color="info"
title="Notes: "
maxLength={167}
text={alertSummary.notes}
showMoreClass="text-info"
/>
</div>
)}
Expand Down
10 changes: 5 additions & 5 deletions ui/shared/TruncatedText.jsx
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ export default class TruncatedText extends React.Component {
}

render() {
const { text, maxLength, title, showMoreClass } = this.props;
const { text, maxLength, title, color } = this.props;
const { showMoreResults } = this.state;

return (
Expand All @@ -22,8 +22,10 @@ export default class TruncatedText extends React.Component {
</p>
{text.length > maxLength && (
<Button
color="link"
className={`${showMoreClass} d-block p-0 ml-auto`}
color={color || 'link'}
yogmel marked this conversation as resolved.
Show resolved Hide resolved
outline={color}
className={`${color ||
'font-weight-bold text-reset'} d-block ml-auto`}
onClick={() => this.setState({ showMoreResults: !showMoreResults })}
>
{`show ${showMoreResults ? 'less' : 'more'}`}
Expand All @@ -38,10 +40,8 @@ TruncatedText.propTypes = {
text: PropTypes.string.isRequired,
title: PropTypes.string,
maxLength: PropTypes.number.isRequired,
showMoreClass: PropTypes.string,
};

TruncatedText.defaultProps = {
showMoreClass: 'font-weight-bold',
title: '',
};