Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React to 18.2 #7798

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Upgrade React to 18.2 #7798

wants to merge 7 commits into from

Conversation

vrigal
Copy link
Collaborator

@vrigal vrigal commented Sep 7, 2023

Duplicate of #7672 (I could not push)

@vrigal vrigal changed the title Upgrade react 18 Upgrade React to 18.2 Sep 7, 2023
@vrigal
Copy link
Collaborator Author

vrigal commented Sep 8, 2023

The upgrade is not finished yet.

Packages that are not marked as compatible with react 18 or related upgrades (warnings using yarn install):

With the current state I got a usable application with some warning/errors:

  • Warning: Encountered two children with the same key, maven-metadata.xml. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
    Warning: Failed prop type: Invalid prop children supplied to ErrorBoundary. (react-hot-loader)
  • Error: Need to retrieve or renew Taskcluster credentials before action can be performed. (getCredentials taskcluster.js:93)

Some tests fails on those modules:

  • tests/ui/perfherder/graphs-view/graphs_view_test.jsx
  • tests/ui/perfherder/graphs-view/test_data_modal_test.jsx
  • tests/ui/perfherder/selector_card_test.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant