Add additional allowed sdp payload types to parse_media. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na-g
requested changes
Mar 11, 2021
na-g
approved these changes
Mar 11, 2021
|
I'm okay with the parser accepting all assigned values, minus what @na-g said making sure Firefox does something sane. But I'm not sure why the parser should accept the unassinged values as well? |
|
Any plans of merging this PR? |
|
@na-g @nils-ohlmeier Just wondering if I should create a separate PR for adding support for additional payload types to parse_media or if there are any plans of merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://tools.ietf.org/html/rfc3551#section-6
and https://tools.ietf.org/html/rfc5761#section-4