Do not assume char is always signed #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is platform-dependent and having it wrong makes the PRId8 and PRIi8 macros print int8_t values as unsigned on some platforms.
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 359 359
=====================================
Hits 359 359
Continue to review full report at Codecov.
|
ledvinap
approved these changes
Jun 5, 2019
|
Can you please merge the PR? @mpaland |
|
@dublevskyi : I've merged this into my fork, which is basically a merge of a bunch of small changes and fixes people have suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is platform-dependent and having it wrong makes the PRId8 and PRIi8 macros print int8_t values as unsigned on some platforms.