-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osxbundle: refactor Information Property List #13723
Conversation
Download the artifacts for this pull request: |
i don't think if we want to support file extensions that aren't defined by Apple we do need to define them and make them conform to one of the existing UTIs, eg with UTExportedTypeDeclarations and UTTypeConformsTo. probably similar to what we or VLC does. |
okay let get this a little bit sorted. lets start by cleaning up the lets keep it to 3 different
after that we start to sort out the
lastly i would go through the list again and add all the other audio/video UTIs to the References: |
I reordered |
okay, i probably can't review your changes this week. it's a bit busy and i am not home at the weekend. just wanted to give you a heads up that i will try to look at everything as soon as possible. |
Thanks, no rush! |
hope i've got everything. |
hope this will be the last batch of comments. |
only this one last thing. after this feel free to squash the commits and force push. then we can finally get this merged. thank you for you hard work on this one, i really appreciate it. |
Includes cleanup of CFBundleDocumentTypes, UTImportedTypeDeclarations, LSItemContentTypes. Reordered general structure of the Property List as in nodes/collections/arrays. Declared MIME types.
Replaces deprecated CFBundleTypeExtensions with LSItemContentTypes.
LSHandlerRank ranks apps that declare as editors or viewers of a specific file type. Default value was chosen since mpv is a viewer of file types as opposed to an editor.
I tested this patch with some filetypes (avi,mkv,mov,wav) and the launch service seemed to behave appropriately.