Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream / file open fixes #14137

Merged
merged 5 commits into from
May 15, 2024
Merged

Stream / file open fixes #14137

merged 5 commits into from
May 15, 2024

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented May 13, 2024

No description provided.

@sfan5 sfan5 force-pushed the streamcont branch 2 times, most recently from 632af91 to f07c55b Compare May 13, 2024 20:20
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Download the artifacts for this pull request:

Windows
macOS

na-na-hi
na-na-hi reviewed May 14, 2024
View reviewed changes
player/misc.c Outdated Show resolved Hide resolved
stream/stream.c Outdated Show resolved Hide resolved
@sfan5
stream: disallow reading or writing to directories
3925fba 
Reading an entire file is a common operation, meanwhile
stream_file will happily open a directory. This doesn't match well.

Analogously for open_output_stream().
kasper93
kasper93 requested changes May 14, 2024
View reviewed changes
stream/stream.c Show resolved Hide resolved
options/parse_configfile.c Outdated Show resolved Hide resolved
player/misc.c Show resolved Hide resolved
stream/stream_slice.c Show resolved Hide resolved
stream/stream_concat.c Show resolved Hide resolved
demux/demux_playlist.c Outdated Show resolved Hide resolved
stream/stream_file.c Outdated Show resolved Hide resolved
kasper93
kasper93 reviewed May 14, 2024
View reviewed changes
stream/stream_file.c Outdated Show resolved Hide resolved
sfan5 added 2 commits May 15, 2024 10:13
@sfan5
{options,player}: fix stream leaks
724bd38
@sfan5
various: add missing checks for directory streams
f8a9e3d 
All of this code opens a stream and expects to read stuff from a file.
But streams can also be directories and that has to be handled.
@sfan5 sfan5 force-pushed the streamcont branch 2 times, most recently from 14c56b2 to 33f1c49 Compare May 15, 2024 08:29
sfan5 added 2 commits May 15, 2024 19:11
@sfan5
stream: check file descriptor passed to fd:// or fdclose://
fe3f98a
@sfan5
stream: remove directory playlist hint
65baceb 
The stream layer is the wrong place to handle this and the benefit
seems dubious.
@sfan5 sfan5 merged commit 03ca340 into mpv-player:master May 15, 2024
18 checks passed
@sfan5 sfan5 deleted the streamcont branch May 15, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasper93 kasper93 kasper93 requested changes

@na-na-hi na-na-hi na-na-hi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfan5 @kasper93 @na-na-hi