Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AsyncClient getters and setters for MqttClient properties #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-goodisman
Copy link

The type definitions claims that AsyncClient extends MqttClient, which implies that all of the public properties present on MqttClient can be accessed on AsyncClient. However, several of the getters and setters are missing. The full list added is:

Properties that had a getter but not setter (setter added):

  • connected
  • reconnecting

Properties that had neither (both added):

  • disconnecting
  • disconnected
  • incomingStore
  • outgoingStore
  • options
  • queueQoSZero

This will allow the AsyncClient to read and modify these values in the same manner as the base class client.

@alex-goodisman
Copy link
Author

The setters may be overkill, but the base mqtt client does allow modifying them in place, so this probably should present the same API. Regardless, it should at least have the missing getters.

Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind updating the index.d.ts typings to match the new properties?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants