fix(conn): password can be set when username unset when mqttv5 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsLando
requested changes
Dec 19, 2023
Highlight: This version of the protocol allows the sending of a Password with no User Name, where MQTT v3.1.1 did not. refer: https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901044 > 3.1.2.9 Password Flag > Position: bit 6 of the Connect Flags. > > If the Password Flag is set to 0, a Password MUST NOT be present in the Payload [MQTT-3.1.2-18]. If the Password Flag is set to 1, a Password MUST be present in the Payload [MQTT-3.1.2-19]. > > Non-normative comment > > This version of the protocol allows the sending of a Password with no User Name, where MQTT v3.1.1 did not. This reflects the common use of Password for credentials other than a password.
JimMoen
force-pushed
the
fix-username-null
branch
from
f843a86
to
65d1cdd
Compare
robertsLando
requested changes
Dec 19, 2023
Comment on lines
+204
to
+205
| // `username` is not required when password is present in MQTT-v5 | ||
| // see also: https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901044 |
There was a problem hiding this comment.
Move this comment above the if for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTT-v5 allows sending a password without username
Which means username flag set
0and username not be present in CONNECT payload.And there is no necessary relationship between Username flag and Password flag.
see also:
https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901044