Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have cibuildwheel create pypy wheels #486

Open
wants to merge 1 commit into
base: hg
Choose a base branch
from
Open

Conversation

dand-oss
Copy link

@dand-oss dand-oss commented Jan 1, 2023

have cibuildwheel create pypy wheels

@mrabarnett
Copy link
Owner

Have you noted that it won't work properly with PyPy because PyPy stores strings using UTF-8?

@dand-oss
Copy link
Author

dand-oss commented Jan 1, 2023

Regex seems to work for my limited use in pypy

I see utf8 storage added 2019
https://www.pypy.org/posts/2019/03/pypy-v71-released-now-uses-utf-8-451324088028792912.html

Appears our tests are only run for python 3.10 in CI rather then the range of python versions supported - shall I add testing for a matrix of python versions to main.yml, then bring any errors up with the pypy team?

@mrabarnett
Copy link
Owner

The regex module is targeted at CPython and it expects all characters/codepoints to be the same width, so if you're working only with U+0000..U+007F (ASCII-range) it'll work, but I really don't want to say that it'll work with PyPy when it's only for that narrow range.

As for CPython versions, it should work the same across the versions except for the change matching behaviour that occurred at Python 3.7. (The re module did the same change.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants